thanks for the nice words and honored to be considered in important packages!

I guess it make sense for us to add devel to CI, we will do that (see pietroppeter/nimib#149)

as mentioned in discord #science chat, toml_serialization (reponsible for current failing checks, as I understand) is a dependency from status, so I will have to follow up with them.

for reference, I am noting also here elements of the discussion in discord #science chat:

• reported error:

  /home/runner/.nimble/pkgs/toml_serialization-0.2.3/toml_serialization/types.nim(172, 25) template/generic instantiation of `==` from here
    /home/runner/work/Nim/Nim/lib/system/comparisons.nim(309, 6) Error: '==' can have side effects
    > /home/runner/work/Nim/Nim/lib/system/comparisons.nim(334, 13) Hint: '==' calls `.sideEffect` '=='
    >> /home/runner/.nimble/pkgs/toml_serialization-0.2.3/toml_serialization/types.nim(144, 6) Hint: '==' called by '=='
  

• devel has enabled stricteffects, it seems that it is necessary to annotate the proc in toml_serialization with noSideEffect. ref fixes #19162; enable strictEffects for v2 #19380
• Does stricteffects break sideeffect analysis?
  • Yeah, it is caused by strictEffects: regression in recursive effect tracking #19303
  • Before Better effect tracking for inner routines RFCs#435 is fixed, there is only a workaround.

• opened an issue in toml_serialization: Library errors with devel after stricteffects enabled status-im/nim-toml-serialization#56
• and a corresponding PR with the noSideEffects annotation: fix failure with devel after stricteffects enabled, fix #56 status-im/nim-toml-serialization#57
• a new error pops out:

C:\Users\ppeterlongo\Documents\toml_serialization\toml_serialization.nim(112, 15) template/generic instantiation of `readValue` from here
C:\Users\ppeterlongo\.nimble\pkgs\serialization-0.1.0\serialization.nim(29, 9) template/generic instantiation of `readValue` from here
C:\Users\ppeterlongo\Documents\toml_serialization\toml_serialization\reader.nim(416, 29) template/generic instantiation from here
C:\Users\ppeterlongo\Documents\toml_serialization\toml_serialization\reader.nim(430, 15) Error: parseValue(r.lex, value) can raise an unlisted exception: Exception

• not sure how to proceed, help appreciated. @ringabout ?

The other issue can be fixed as status-im/nim-toml-serialization#55

Looks as though this is still failing on Linux and Mac OS.

Well the PR on toml serialization was merged with failing checks. I assume the maintainers of that package will take over the fix (I was kind of stuck but there was some suggestions, I would have probably moved much slower than them). Until the issue is actually solved (green CI on toml-serialization), I do not expect this to go green.

The blocker for this is currently status-im/nim-serialization#45

blocker was fixed (and nim serialization does not have release so it should be already picked up as a dependency) so we could try running again the CI

I actually expect this to fail again. we have set up devel CI in nimib (pietroppeter/nimib#169) and there is now a new reason for failure (not related to toml-serialization). We will look into it and update here when solved.

The same toml problem still exists after fixing the new error (which was caused by #21326): see error logs. So it seems like the PR didn't fix our problem.

with the latest nimib release we should be good to go for this (you could rerun checks): https://github.com/pietroppeter/nimib/releases/tag/v0.3.6

(wow so fast!)

(wow so fast!)

Yeah, I have been watching the progress of this issue, thanks for your diligent work!

thanks for your diligent work!

it's all thanks to @HugoGranstrom! 👏

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from be49126

Hint: mm: orc; opt: speed; options: -d:release
166065 lines; 8.101s; 611.098MiB peakmem